Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add kubernetes_token_request resource #2024

Merged
merged 24 commits into from
Mar 20, 2023
Merged

Add kubernetes_token_request resource #2024

merged 24 commits into from
Mar 20, 2023

Conversation

BBBmau
Copy link
Contributor

@BBBmau BBBmau commented Mar 1, 2023

Description

Allows the ability to request a Token for a service account using the TokenRequest API, kubernetes_token_request
Fixes #1821

Acceptance tests

  • Have you added an acceptance test for the functionality being added?
  • Have you run the acceptance tests on this branch?

Output from acceptance testing:

➜  terraform-provider-kubernetes git:(add-tokenrequest-resource) ✗ make testacc TESTARGS="-run TestAccKubernetesTokenRequest_basic"
==> Checking that code complies with gofmt requirements...
go vet .
TF_ACC=1 go test "/Users/mau/Dev/terraform-provider-kubernetes/kubernetes" -v -run TestAccKubernetesTokenRequest_basic -timeout 3h
=== RUN   TestAccKubernetesTokenRequest_basic
--- PASS: TestAccKubernetesTokenRequest_basic (9.44s)
PASS
ok      github.com/hashicorp/terraform-provider-kubernetes/kubernetes   10.144s

Release Note

Release note for CHANGELOG:

`kubernetes/resource_kubernetes_tokenrequest.go`: Add `kubernetes_token_request_v1` resource

References

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

@github-actions github-actions bot added the size/L label Mar 1, 2023
@github-actions github-actions bot added size/XL and removed size/L labels Mar 1, 2023
@github-actions github-actions bot added size/L and removed size/XL labels Mar 2, 2023
@BBBmau BBBmau marked this pull request as ready for review March 7, 2023 01:10
@BBBmau BBBmau requested a review from a team as a code owner March 7, 2023 01:10
website/docs/r/token_request_v1.html.markdown Outdated Show resolved Hide resolved
kubernetes/schema_token_request.go Outdated Show resolved Hide resolved
kubernetes/schema_token_request.go Outdated Show resolved Hide resolved
kubernetes/schema_token_request.go Outdated Show resolved Hide resolved
kubernetes/resource_kubernetes_tokenrequest_test.go Outdated Show resolved Hide resolved
kubernetes/resource_kubernetes_tokenrequest_test.go Outdated Show resolved Hide resolved
website/docs/r/token_request_v1.html.markdown Outdated Show resolved Hide resolved
kubernetes/schema_token_request.go Outdated Show resolved Hide resolved
kubernetes/structures_tokenrequest.go Outdated Show resolved Hide resolved
kubernetes/structures_tokenrequest.go Outdated Show resolved Hide resolved
kubernetes/structures_tokenrequest.go Outdated Show resolved Hide resolved
kubernetes/structures_tokenrequest.go Outdated Show resolved Hide resolved
kubernetes/schema_token_request.go Outdated Show resolved Hide resolved
Copy link
Collaborator

@jrhouston jrhouston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple more things, almost there! 😅

kubernetes/resource_kubernetes_tokenrequest.go Outdated Show resolved Hide resolved
kubernetes/structures_tokenrequest.go Outdated Show resolved Hide resolved
kubernetes/schema_token_request.go Show resolved Hide resolved
Copy link
Collaborator

@jrhouston jrhouston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 🚀 🚀

@BBBmau BBBmau merged commit 5af008f into main Mar 20, 2023
@BBBmau BBBmau deleted the add-tokenrequest-resource branch March 20, 2023 20:52
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Data resource for TokenRequest API
3 participants