Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update EKS example to use two applies #1260

Merged
merged 3 commits into from
May 13, 2021
Merged

Conversation

dak1n1
Copy link
Contributor

@dak1n1 dak1n1 commented May 7, 2021

Description

In order to avoid provider configuration issues associated with a single-apply create, use two applies, and use the AWS provider rather than the EKS module.

Acceptance tests

  • Have you added an acceptance test for the functionality being added?
  • Have you run the acceptance tests on this branch?

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX'

...

Release Note

Release note for CHANGELOG:

Update EKS example to use two applies.

References

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

@ghost ghost added size/XL labels May 7, 2021
In order to avoid provider configuration issues associated with a single-apply create, use two applies, and use the AWS provider rather than the EKS cluster module.
@dak1n1 dak1n1 force-pushed the update_eks_example branch from f93aa26 to f74e08f Compare May 7, 2021 22:01
@dak1n1 dak1n1 requested a review from a team May 13, 2021 16:33
Copy link
Collaborator

@jrhouston jrhouston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating this @dak1n1

@dak1n1 dak1n1 merged commit a3546ce into hashicorp:main May 13, 2021
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants