Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vendor auth plugins #11

Merged
merged 3 commits into from
Jun 23, 2017
Merged

Conversation

e-max
Copy link
Contributor

@e-max e-max commented Jun 22, 2017

We vendor all available in version 3.0.0-beta.0 auth plugins

"version": "v3.0.0-beta.0",
"versionExact": "v3.0.0-beta.0"
"revision": "51bf18f5e6291a6e27dc267e99def9635dc2e1c2",
"revisionTime": "2017-06-22T03:54:09Z"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please keep this pinned to v3.0.0-beta.0? From my past experience it's usually better to stick to tagged releases as they tend to be stable than untagged revisions.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting. I didn't do it manually, it was a govendor job. I'll fix it, give me a sec.

Copy link
Member

@radeksimko radeksimko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just to keep things clean it would be nice to govendor remove k8s.io/client-go/plugin/pkg/client/auth/gcp since we now import the parent package.
But I can do it for you prior/after merge if you want. 😉

@radeksimko
Copy link
Member

Awesome 🎉 thanks for the quick response.

@radeksimko radeksimko merged commit 7efd6bf into hashicorp:master Jun 23, 2017
ddub pushed a commit to ddub/terraform-provider-kubernetes that referenced this pull request Jun 21, 2018
Support Kubernetes v1.9.0 and apps/v1 API
@ghost ghost locked and limited conversation to collaborators Apr 22, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants