-
Notifications
You must be signed in to change notification settings - Fork 985
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vendor auth plugins #11
Conversation
vendor/vendor.json
Outdated
"version": "v3.0.0-beta.0", | ||
"versionExact": "v3.0.0-beta.0" | ||
"revision": "51bf18f5e6291a6e27dc267e99def9635dc2e1c2", | ||
"revisionTime": "2017-06-22T03:54:09Z" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please keep this pinned to v3.0.0-beta.0
? From my past experience it's usually better to stick to tagged releases as they tend to be stable than untagged revisions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interesting. I didn't do it manually, it was a govendor job. I'll fix it, give me a sec.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just to keep things clean it would be nice to govendor remove k8s.io/client-go/plugin/pkg/client/auth/gcp
since we now import the parent package.
But I can do it for you prior/after merge if you want. 😉
Awesome 🎉 thanks for the quick response. |
Support Kubernetes v1.9.0 and apps/v1 API
We vendor all available in version 3.0.0-beta.0 auth plugins