resource/kubernetes_secret: Prevent binary data corruption #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
radeksimko
approved these changes
Feb 22, 2018
There was a problem hiding this comment.
Sorry for the delay in reviewing this.
Thanks for the patch and the attached test. Both look great 👍
=== RUN TestAccKubernetesSecret_basic
--- PASS: TestAccKubernetesSecret_basic (0.24s)
=== RUN TestAccKubernetesSecret_importBasic
--- PASS: TestAccKubernetesSecret_importBasic (0.07s)
=== RUN TestAccKubernetesSecret_generatedName
--- PASS: TestAccKubernetesSecret_generatedName (0.06s)
=== RUN TestAccKubernetesSecret_importGeneratedName
--- PASS: TestAccKubernetesSecret_importGeneratedName (0.07s)
=== RUN TestAccKubernetesSecret_binaryData
--- PASS: TestAccKubernetesSecret_binaryData (0.12s)
radeksimko
changed the title
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this change, when creating a secret containing binary data (e.g. where the data value is read from a binary file with
${file(....)}), the data would be corrupt after the initialapply.A subsequent
applywould detect the binary data does not match the source and it would be corrected.