Can not create a persistent volume claim with a storage class annotation

[tdmalone]

Terraform Version

Terraform v0.11.13
+ provider.aws v1.60.0
+ provider.external v1.0.0
+ provider.http v1.0.1
+ provider.kubernetes v1.5.2
+ provider.null v2.1.0
+ provider.template v2.1.0

Affected Resource(s)

• kubernetes_persistent_volume_claim

Terraform Configuration Files

(from https://github.com/kubernetes-incubator/external-storage/tree/master/aws/efs, converted to Terraform)

resource "kubernetes_persistent_volume_claim" "efs" {
  metadata {
    name = "efs"

    annotations = {
      "volume.beta.kubernetes.io/storage-class" = "${kubernetes_storage_class.aws_efs.metadata.0.name}"
    }
  }

  spec {
    access_modes = ["ReadWriteMany"]

    resources {
      request {
        storage = "1Mi"
      }
    }
  }
}

Expected Behavior

Volume claim resource should have been created.

Actual Behavior

Error: kubernetes_persistent_volume_claim.efs: metadata.0.annotations: "volume.beta.kubernetes.io/storage-class" is internal Kubernetes annotation

Steps to Reproduce

1. Add the above configuration
2. Run terraform apply

References

• caused by meta: Treat internal k8s annotations as invalid #50
• similar issues in Can not set internal annotations to specify load balancer ssl certs #60, Metadata annotations generate an internal Kubernetes annotation errors #200 and Secret type service-account-token cannot be created #254
• would be fixed by Revert "meta: Treat internal k8s annotations as invalid" #199 and add internal annotation whitelist #244

[tdmalone]

Oops it appears volume.beta.kubernetes.io/storage-class has been deprecated anyway:
https://kubernetes.io/docs/concepts/storage/persistent-volumes/#class

The new way to reference this is the spec.storage_class_name attribute.