Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add debug message for cluster unreachable at plan time #962

Merged
merged 1 commit into from
Sep 29, 2022

Conversation

jrhouston
Copy link
Contributor

The CustomizeDiffFunc function doesn't allow us to surface diagnostic messages when something goes wrong, only errors.

We don't want the plan to fail so instead we mark "manifest" as computed and swallow the error, and write a debug log.

Description

Acceptance tests

  • Have you added an acceptance test for the functionality being added?

Release Note

Release note for CHANGELOG:

...

References

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

The CustomizeDiffFunc function doesn't allow us to surface
diagnostic messages when something goes wrong, only errors.

We don't want the plan to fail so instead we mark "manifest"
as computed and swallow the error, and write a debug log.
Copy link
Member

@alexsomesan alexsomesan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems legit

@jrhouston jrhouston merged commit 5155c90 into main Sep 29, 2022
@jrhouston jrhouston deleted the unreachable-debug branch September 29, 2022 20:50
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants