The current state of helm_template with test passing #1532
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Previously, helm_template failed in the entire test suite. After taking a look, a lot of the
Read
functions logic didn't address key points, or had logic in incorrect spots. This pr fixes those hiccups, and now we have 3/4 test passing, in the test suite now. The remaining failed test, I will debug and fix in a follow up pr!The two test configs, needs the set attributes fixed! You might not see the test passing currently, due to me fixing the test config, in a previous pr!
Acceptance tests
Acceptance test:
Release Note
Release note for CHANGELOG:
References
Community Note