Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removing marshaling and unmarshaling and replacing with maps.clone #1524

Merged
merged 1 commit into from
Nov 22, 2024
Merged

Removing marshaling and unmarshaling and replacing with maps.clone #1524

merged 1 commit into from
Nov 22, 2024
+3 −14

Conversation

JaylonmcShan03
Copy link
Contributor

Description

This pr removes marshalling and unmarshalling a json to a map in the logValues function, and is now using maps.clone.

Acceptance tests

  • Have you added an acceptance test for the functionality being added?

Release Note

Release note for CHANGELOG:

...

References

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

@JaylonmcShan03 JaylonmcShan03 requested a review from a team as a code owner October 29, 2024 15:09
@JaylonmcShan03 JaylonmcShan03 merged commit 7d6cb2f into helm-framework Nov 22, 2024
5 of 10 checks passed
@JaylonmcShan03 JaylonmcShan03 deleted the remove-json-marshal-unmarshal-to-maps-clone branch November 22, 2024 13:45
@JaylonmcShan03 JaylonmcShan03 self-assigned this Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arybolovlev arybolovlev arybolovlev approved these changes

Assignees

@JaylonmcShan03 JaylonmcShan03

Labels
size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JaylonmcShan03 @arybolovlev