Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update changelog for 0.4.0 release #98

Merged
merged 3 commits into from
Apr 7, 2021
Merged

Update changelog for 0.4.0 release #98

merged 3 commits into from
Apr 7, 2021

Conversation

bcmdarroch
Copy link
Contributor

πŸ› οΈ Description

We got Vault resources and Consul cluster VM sizes incoming! πŸš€

@bcmdarroch bcmdarroch self-assigned this Apr 7, 2021
@bcmdarroch bcmdarroch requested a review from a team April 7, 2021 00:43
Copy link
Contributor

@roaks3 roaks3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving so that it isn't blocked from merging, but I think this also needs the updates to examples/provider/provider.tf for the main example snippet that people are most likely to copy-paste (similar to previous PRs: https://github.com/hashicorp/terraform-provider-hcp/pull/87/files)

CHANGELOG.md Outdated

IMPROVEMENTS:

- all: General chores (#82)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh sorry, should have maybe made it more clear, but I thought we'd break these out into individual items:

FIXES:
- all: Ensure context is being passed for all HCP API calls (#82)

IMPROVEMENTS
resource/aws_network_peering: Update comments, docs, and messages to use correct capitalization for network peering (#82)
all: Log import ID used when an import fails due to parsing (#82)
all: Add comment to clarify that Links can be sent in API requests (#82)
resource/aws_network_peering: Update peering wait function to use helper (#82)

CHANGELOG.md Outdated
@@ -1,3 +1,19 @@
## 0.4.0 (April 6, 2021)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we want (Unreleased) here for the date, and then the TeamCity job takes care of replacing with the date

@bcmdarroch bcmdarroch merged commit 217a260 into main Apr 7, 2021
@bcmdarroch bcmdarroch deleted the update-changelog branch April 7, 2021 15:11
aidan-mundy pushed a commit that referenced this pull request Sep 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants