HCPE-955: Vault resources #97
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roaks3
approved these changes
Apr 6, 2021
stub out vault cluster CRUD and add timeouts add vault cluster resource schema add vault cluster admin token resource stub add vault cluster resource schema and CRUD stubs add created_at to vault cluster
output admin_token -> token so not redundant drop answered questions drop update add Read function for admin_token drop max_lease_ttl and move namespace to computed outputs tier can only be dev currently, so change to computed output fix tests initial_vault_version -> min_vault_version
add GetVaultClusterByID helper add CreateVaultCluster helper add DeleteVaultCluster helper add CreateVaultClusterAdminToken helper
into new input package to be shared across resources
add resourceVaultClusterCreate and setVaultClusterResourceData add resourceVaultClusterRead add resourceVaultClusterDelete
HCPE-980: Vault cluster resource
and update test
fix import
gen docs
add resourceVaultClusterAdminTokenCreate add resourceVaultClusterAdminTokenRead & Delete
update comments + change delete behavior
fix description add resource template + example .tf gen doc add adminTokenExpiry drop min_version from test tf regen docs
instead of calling Create, which entangled those two functions
bcmdarroch
force-pushed
the
hcpe-955-vault-resources-2
branch
from
58fd325 to
7d0bf5b
Compare
xargs-P
reviewed
Apr 7, 2021
| This resource saves a single admin token per Vault cluster and auto-refreshes the token when it is about to expire. | ||
| Destroying this resource *does not* invalidate the admin token. | ||
|
|
||
| ~> **Known Issue** An admin token may be generated during a `terraform plan` if the current token is expiring. |
xargs-P
reviewed
Apr 7, 2021
|
|
||
| # Resource `hcp_vault_cluster_admin_token` | ||
|
|
||
| ~> **Important Security Notice** The admin token generated by this resource will |
There was a problem hiding this comment.
Is there a similar problem with Consul tokens @bcmdarroch ? 🤔
I thought it was encrypted.
There was a problem hiding this comment.
It is but not in all cases: https://www.terraform.io/docs/language/state/sensitive-data.html
aidan-mundy
pushed a commit
that referenced
this pull request
Sep 8, 2023
EPT-77 Change Code Owners to EPT Pod
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🛠️ Description
Feature branch for the Vault resources:
hcp_vault_clusterandhcp_vault_cluster_admin_token🔒 🔑 ✨🏗️ Acceptance tests
Output from acceptance testing: