Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HCPE-926 - Add github checks for depscheck, fmtcheck, and gencheck #90

Merged
merged 1 commit into from
Mar 30, 2021

Conversation

roaks3
Copy link
Contributor

@roaks3 roaks3 commented Mar 26, 2021

🛠️ Description

Added GitHub checks (and make targets) for:

  • depscheck - Run go mod tidy and make sure there are no differences
  • fmtcheck - Make sure gofmt has been run on all Go files
  • gencheck - Run go generate and make sure there are no differences

I chose these checks to start since they don't require any additional tools to run. Also note that there is no cache being used here, so that might be something we want to look at if these checks start taking a long time to run.

For reference:

🏗️ Acceptance tests

  • Are there any feature flags that are required to use this functionality?
  • Have you added an acceptance test for the functionality being added?
  • Have you run the acceptance tests on this branch?

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX'

...

@roaks3 roaks3 requested a review from a team March 26, 2021 17:52
Copy link
Contributor

@bcmdarroch bcmdarroch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yaaa! 🙌

@roaks3 roaks3 merged commit ebffa40 into main Mar 30, 2021
@roaks3 roaks3 deleted the HCPE-926-more-github-checks branch March 30, 2021 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants