HCPE-996 - Add pull request lifecycle docs #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roaks3
commented
Mar 26, 2021
| @@ -0,0 +1,46 @@ | |||
| # Pull Request Submission and Lifecycle | |||
There was a problem hiding this comment.
Most of this content is sourced from other repos: Kubernetes provider, AWS provider
roaks3
commented
Mar 26, 2021
Comment on lines
+3
to
+7
| __Note for internal service teams__: The pull request lifecycle below will be | ||
| roughly the same for internal teams, but you will not need to fork the repo to | ||
| create pull requests, and our recommendation is to get a review from one other | ||
| member of your service team, in addition to a review from one member of the | ||
| provider team. |
There was a problem hiding this comment.
This is the main note I added to address internal team members
roaks3
commented
Mar 26, 2021
Comment on lines
+41
to
+43
| releasing new versions of the provider. Please ask a provider team member | ||
| about the timing of the next release if the change you are making is | ||
| time-sensitive. Generally, releases are done roughly every two weeks. |
There was a problem hiding this comment.
These sentences at the end were added to set expectations for contributors on when their changes will be released (mainly aimed toward internal teams that have their own timelines to work with)
roaks3
force-pushed
the
HCPE-996-pr-lifecycle
branch
from
cb27906 to
2d7c15f
Compare
roaks3
changed the title
bcmdarroch
reviewed
Mar 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🛠️ Description
Added docs to describe the PR lifecycle, meant primarily for new contributors.
🏗️ Acceptance tests
Output from acceptance testing: