Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add changelog for #862 documentation fix #867

Merged
merged 2 commits into from
Jun 13, 2024
Merged

Add changelog for #862 documentation fix #867

merged 2 commits into from
Jun 13, 2024

Conversation

averche
Copy link
Contributor

@averche averche commented Jun 13, 2024

🛠️ Description

A changelog is required in order to publish another release

🏗️ Acceptance tests

  • Are there any feature flags that are required to use this functionality?
  • Have you added an acceptance test for the functionality being added?
  • Have you run the acceptance tests on this branch?

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX'

...

@averche averche requested a review from a team as a code owner June 13, 2024 16:28
Copy link
Member

@jasonpilz jasonpilz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@averche averche added the pr/no-changelog Auto-pinning label Jun 13, 2024
@jasonpilz
Copy link
Member

Should the file be 867.txt?

@averche
Copy link
Contributor Author

averche commented Jun 13, 2024

Should the file be 867.txt?

I thought it would be more approriate to match it to the PR that it affects (#862), happy to change it though

@averche averche removed the pr/no-changelog Auto-pinning label Jun 13, 2024
@averche averche merged commit 4262c4d into main Jun 13, 2024
6 checks passed
@averche averche deleted the docs-changelog branch June 13, 2024 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants