Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add in-place update to HCP Log Streaming Destination #802

Merged
merged 4 commits into from
Apr 4, 2024

Conversation

leahrob
Copy link
Contributor

@leahrob leahrob commented Apr 1, 2024

Adding in-place update functionality to the HCP Log Streaming Destination resource. IFACE-2608

🛠️ Description

🏗️ Acceptance tests

  • Are there any feature flags that are required to use this functionality?
  • Have you added an acceptance test for the functionality being added?
  • Have you run the acceptance tests on this branch?

Output from acceptance testing:

TestAccHCPLogStreamingDestinationCloudwatch
$ make testacc TESTARGS='-run=TestAccHCPLogStreamingDestinationCloudwatch'
==> Checking that code complies with gofmt requirements...
golangci-lint run --config ./golangci-config.yml 
TF_ACC=1 go test ./internal/... -v -run=TestAccHCPLogStreamingDestinationCloudWatch -timeout 360m -parallel=10

=== RUN   TestAccHCPLogStreamingDestinationCloudWatch
--- PASS: TestAccHCPLogStreamingDestinationCloudWatch (6.36s)
PASS
ok      github.com/hashicorp/terraform-provider-hcp/internal/provider/logstreaming      7.483s
TestAccHCPLogStreamingDestinationSplunk
$ make testacc TESTARGS='-run=TestAccHCPLogStreamingDestinationSplunk'
==> Checking that code complies with gofmt requirements...
golangci-lint run --config ./golangci-config.yml 
TF_ACC=1 go test ./internal/... -v -run=TestAccHCPLogStreamingDestinationSplunk -timeout 360m -parallel=10

=== RUN   TestAccHCPLogStreamingDestinationSplunk
--- PASS: TestAccHCPLogStreamingDestinationSplunk (5.53s)
PASS
ok      github.com/hashicorp/terraform-provider-hcp/internal/provider/logstreaming      6.067s

@leahrob leahrob changed the title IFACE-2608: add in-place update to hcp log streaming destination resource Add in-place update to HCP Log Streaming Destination Apr 2, 2024
@leahrob leahrob marked this pull request as ready for review April 2, 2024 21:55
@leahrob leahrob requested a review from a team as a code owner April 2, 2024 21:55
@leahrob leahrob merged commit ff7a0bc into main Apr 4, 2024
6 checks passed
@leahrob leahrob deleted the iface-2608-add-update-hcp-log-streaming-dest branch April 4, 2024 16:40
catsby added a commit that referenced this pull request Apr 5, 2024
* main:
  updated documentation
  updated CHANGELOG.md
  Add DataDog config to HCP Log Streaming Destination (#803)
  Add in-place update to HCP Log Streaming Destination (#802)
  Update error messages in HCP provider config
  Refactor code to require specific organization configuration
  changelog
  Handle multiple organizations for credentials
  Fixed HttpCodec Check (#781)
  updated documentation
  updated CHANGELOG.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants