Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HCPE-1000 - Update contribution docs to include guidance on acceptance tests #79

Merged
merged 3 commits into from
Mar 23, 2021

Conversation

roaks3
Copy link
Contributor

@roaks3 roaks3 commented Mar 19, 2021

Add documentation for running and writing acceptance tests.

This is largely copied from https://github.com/hashicorp/terraform-provider-aws/blob/master/docs/contributing/running-and-writing-acceptance-tests.md, and tweaked for this project specifically.

@roaks3 roaks3 requested a review from a team March 19, 2021 19:57
Copy link
Contributor

@bcmdarroch bcmdarroch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is super informative! I think the only thing missing is a summary of the minimum test assertions to include (based on what you have here: test the resource exists, test the required inputs are given)

contributing/writing-tests.md Show resolved Hide resolved
contributing/writing-tests.md Show resolved Hide resolved
contributing/writing-tests.md Show resolved Hide resolved
contributing/writing-tests.md Show resolved Hide resolved
Base automatically changed from HCPE-1032-consul-acc-test to main March 22, 2021 18:51
@roaks3 roaks3 force-pushed the HCPE-1000-acc-test-documentation branch from dade6aa to b9b8a06 Compare March 23, 2021 14:09
@roaks3 roaks3 merged commit bf86220 into main Mar 23, 2021
@roaks3 roaks3 deleted the HCPE-1000-acc-test-documentation branch March 23, 2021 14:20
aidan-mundy pushed a commit that referenced this pull request Sep 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants