HCPE-1032 - Add basic consul acceptance test #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bcmdarroch
reviewed
Mar 22, 2021
| @@ -11,7 +11,7 @@ import ( | |||
| ) | |||
|
|
|||
| var ( | |||
| hvn = fmt.Sprintf(` | |||
| testAccHvnConfig = fmt.Sprintf(` | |||
There was a problem hiding this comment.
is this a convention we need to follow?
There was a problem hiding this comment.
No, I only changed this so that the name was more clear and less likely to be reused by other code in the package
bcmdarroch
approved these changes
Mar 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a simple Consul acceptance test, which mainly just verifies that all of the fields get set appropriately on create.
Note for anyone interested in testing this locally: this test was taking >10 mins for me to run.