Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CloudWatch config to HCP Log Streaming Destination #757

Merged
merged 5 commits into from
Feb 21, 2024

Conversation

leahrob
Copy link
Contributor

@leahrob leahrob commented Feb 16, 2024

Adding cloudwatch as a config option for the HCP Log Streaming Destination resource. IFACE-2483

🛠️ Description

🏗️ Acceptance tests

  • Are there any feature flags that are required to use this functionality?
  • Have you added an acceptance test for the functionality being added?
  • Have you run the acceptance tests on this branch?

Output from acceptance testing:

TestAccHCPLogStreamingDestinationCloudwatch
$ make testacc TESTARGS='-run=TestAccHCPLogStreamingDestinationCloudwatch'
==> Checking that code complies with gofmt requirements...
golangci-lint run --config ./golangci-config.yml 
TF_ACC=1 go test ./internal/... -v -run=TestAccHCPLogStreamingDestinationCloudWatch -timeout 360m -parallel=10

=== RUN   TestAccHCPLogStreamingDestinationCloudWatch
--- PASS: TestAccHCPLogStreamingDestinationCloudWatch (6.36s)
PASS
ok      github.com/hashicorp/terraform-provider-hcp/internal/provider/logstreaming      7.483s

@leahrob leahrob marked this pull request as ready for review February 16, 2024 20:07
@leahrob leahrob requested a review from a team as a code owner February 16, 2024 20:07
@manish-hashicorp
Copy link
Contributor

Rubber stamping. Please get approval from your team before merging.

@leahrob leahrob merged commit db4f2de into main Feb 21, 2024
6 checks passed
@leahrob leahrob deleted the iface-2483-add-cloudwatch-streaming-destination branch February 21, 2024 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants