[HCP Vault Secrets] fix app & secret name validation #750
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rodrigo-hcp
approved these changes
Feb 9, 2024
manish-hashicorp
approved these changes
Feb 9, 2024
VinnyHC
approved these changes
Feb 9, 2024
| @@ -50,19 +50,23 @@ func (r *resourceVaultsecretsSecret) Schema(_ context.Context, _ resource.Schema | |||
| Description: "The name of the application the secret can be found in", | |||
| Required: true, | |||
| Validators: []validator.String{ | |||
| stringvalidator.LengthAtLeast(3), | |||
There was a problem hiding this comment.
Apps use this common "hcp user settable slug":
https://github.com/hashicorp/cloud-vault-secrets/blob/main/internal/service/validation/service.go#L37
Wonder if it make sense to adopt this:
https://github.com/hashicorp/terraform-provider-hcp/blob/main/internal/providersdkv2/validators.go#L138
There was a problem hiding this comment.
Great find, did not know it exists! Thanks @VinnyHC
There was a problem hiding this comment.
Unfortunately, it seems like these helpers are internal to providersdkv2 package and can't be used here cleanly.
fhemberger
reviewed
Feb 12, 2024
| regexp.MustCompile(`^[-\da-zA-Z]{3,36}$`), | ||
| "must contain only letters, numbers or hyphens", | ||
| regexp.MustCompile(`^[a-zA-Z0-9][a-zA-Z0-9\-]+[a-zA-Z0-9]$`), | ||
| "must contain only ASCII letters, numbers, and hyphens; must not start or end with a hyphen", |
There was a problem hiding this comment.
@averche Error message should contain min/max length as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🛠️ Description
Fixing the validation rules for HCP Vault Secrets app and secret names to match what we have on the server.
Fixes #728
🏗️ Acceptance tests