Error out if creds has no project access #748
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We recently introduced no-role access which allows a user to become member of the org without access to any project. If such a user tries to use the provider then it will panic because the provider expects to have at least one project in project.List response which in this case will be empty array. Instead of panicing, error out saying the provider needs access to at least one project.
dmalch-hashicorp
approved these changes
Feb 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🛠️ Description
We recently introduced no-role access which allows a user to become member of the org without access to any project. If such a user tries to use the provider then it will panic because the provider expects to have at least one project in
project.Listresponse which in this case will be empty array. Instead of panicing, error out saying the provider needs access to at least one project.🏗️ Acceptance tests
Output from acceptance testing:
$ make testacc TESTARGS='-run=TestAccXXX' ...