Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

packerv2: warn of hcp_packer_image depreciation #735

Merged
merged 3 commits into from
Jan 29, 2024

Conversation

lbajolet-hashicorp
Copy link
Contributor

🛠️ Description

Since hcp_packer_image is being superseded by hcp_packer_artifact, we warn that it will eventually be removed and that its uses should be updated to use the new data source.

🏗️ Acceptance tests

  • Are there any feature flags that are required to use this functionality? - No
  • Have you added an acceptance test for the functionality being added? - No
  • Have you run the acceptance tests on this branch? - Yes

Output from acceptance testing:

╷
│ Warning: Deprecated Resource
│ 
│   with data.hcp_packer_image.img,
│   on channel_setup.hcl.tf line 18, in data "hcp_packer_image" "img":
│   18: data "hcp_packer_image" "img" {
│ 
│ This data source has been deprecated. Use the new `hcp_packer_artifact`
│ data source instead.
│ 
│ (and one more similar warning elsewhere)
╵

@lbajolet-hashicorp lbajolet-hashicorp added the documentation Improvements or additions to documentation label Jan 25, 2024
@lbajolet-hashicorp lbajolet-hashicorp requested a review from a team as a code owner January 25, 2024 21:55
Since hcp_packer_image is being superseded by hcp_packer_artifact, we
warn that it will eventually be removed and that its uses should be
updated to use the new data source.
Copy link
Contributor

@nywilken nywilken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch.

@sylviamoss sylviamoss merged commit 50b1a77 into main Jan 29, 2024
6 checks passed
@sylviamoss sylviamoss deleted the warn_hcp_packer_image_deprecated branch January 29, 2024 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants