HCPE-992 - Update github action to run unit tests instead of acceptance tests #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bcmdarroch
approved these changes
Mar 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The GitHub actions we use for PRs previously included running the acceptance tests (this came from the scaffolding). Since we have no acceptance tests yet, this was effectively only running unit tests and did not cause any problems, but when we start to add acceptance tests to this repository the job would fail due to authentication.
This changeset modifies the GitHub action to only run unit tests, so that we can begin to add acceptance tests without issue. Since HCP resources cost real money to provision, we do not plan to include acceptance tests as part of the GitHub checks moving forward.