HCP Packer new data sources and nomenclature changes #726

sylviamoss · 2024-01-19T17:52:47Z

🛠️ Description

Migrate HCP Packer integration to HCP Packer API V2
Deprecate existing data sources and add new data sources
Deprecated existing resource attributes and new nomenclature replacements
Make necessary nomenclature changes in the verbiage and code base

🏗️ Acceptance tests

Are there any feature flags that are required to use this functionality?
Have you added an acceptance test for the functionality being added?
Have you run the acceptance tests on this branch?

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAcc.*Packer.* -test.v'
==> Checking that code complies with gofmt requirements...
golangci-lint run --config ./golangci-config.yml
TF_ACC=1 go test ./internal/... -v -run=TestAcc.*Packer.* -test.v -timeout 360m -parallel=10
?   	github.com/hashicorp/terraform-provider-hcp/internal/clients/iampolicy	[no test files]
?   	github.com/hashicorp/terraform-provider-hcp/internal/clients/packerv1	[no test files]
?   	github.com/hashicorp/terraform-provider-hcp/internal/clients/packerv2	[no test files]
testing: warning: no tests to run
PASS
ok  	github.com/hashicorp/terraform-provider-hcp/internal/clients	(cached) [no tests to run]
testing: warning: no tests to run
PASS
ok  	github.com/hashicorp/terraform-provider-hcp/internal/consul	(cached) [no tests to run]
testing: warning: no tests to run
PASS
ok  	github.com/hashicorp/terraform-provider-hcp/internal/hcpvalidator	(cached) [no tests to run]
testing: warning: no tests to run
PASS
ok  	github.com/hashicorp/terraform-provider-hcp/internal/input	(cached) [no tests to run]
?   	github.com/hashicorp/terraform-provider-hcp/internal/provider	[no test files]
?   	github.com/hashicorp/terraform-provider-hcp/internal/provider/acctest	[no test files]
?   	github.com/hashicorp/terraform-provider-hcp/internal/provider/customtypes	[no test files]
testing: warning: no tests to run
PASS
ok  	github.com/hashicorp/terraform-provider-hcp/internal/provider/iam	(cached) [no tests to run]
?   	github.com/hashicorp/terraform-provider-hcp/internal/provider/packer	[no test files]
testing: warning: no tests to run
PASS
ok  	github.com/hashicorp/terraform-provider-hcp/internal/provider/logstreaming	(cached) [no tests to run]
?   	github.com/hashicorp/terraform-provider-hcp/internal/provider/packer/testutils	[no test files]
?   	github.com/hashicorp/terraform-provider-hcp/internal/provider/packer/testutils/configbuilder	[no test files]
?   	github.com/hashicorp/terraform-provider-hcp/internal/provider/packer/testutils/configbuilder/packerconfig	[no test files]
?   	github.com/hashicorp/terraform-provider-hcp/internal/provider/packer/testutils/testcheck	[no test files]
?   	github.com/hashicorp/terraform-provider-hcp/internal/provider/packer/testutils/testclient	[no test files]
?   	github.com/hashicorp/terraform-provider-hcp/internal/provider/packer/utils	[no test files]
?   	github.com/hashicorp/terraform-provider-hcp/internal/provider/packer/utils/base	[no test files]
?   	github.com/hashicorp/terraform-provider-hcp/internal/provider/packer/utils/location	[no test files]
=== RUN   TestAcc_Packer_Data_Artifact
=== PAUSE TestAcc_Packer_Data_Artifact
=== RUN   TestAcc_Packer_Data_Artifact_InvalidInputs
=== PAUSE TestAcc_Packer_Data_Artifact_InvalidInputs
=== CONT  TestAcc_Packer_Data_Artifact
=== CONT  TestAcc_Packer_Data_Artifact_InvalidInputs
--- PASS: TestAcc_Packer_Data_Artifact_InvalidInputs (0.29s)
--- PASS: TestAcc_Packer_Data_Artifact (45.03s)
PASS
ok  	github.com/hashicorp/terraform-provider-hcp/internal/provider/packer/sources/artifact	(cached)
=== RUN   TestAcc_Packer_Data_Version_Simple
=== PAUSE TestAcc_Packer_Data_Version_Simple
=== RUN   TestAcc_Packer_Data_Version_InvalidInputs
=== PAUSE TestAcc_Packer_Data_Version_InvalidInputs
=== CONT  TestAcc_Packer_Data_Version_Simple
=== CONT  TestAcc_Packer_Data_Version_InvalidInputs
--- PASS: TestAcc_Packer_Data_Version_InvalidInputs (0.27s)
--- PASS: TestAcc_Packer_Data_Version_Simple (41.33s)
PASS
ok  	github.com/hashicorp/terraform-provider-hcp/internal/provider/packer/sources/version	(cached)
testing: warning: no tests to run
PASS
ok  	github.com/hashicorp/terraform-provider-hcp/internal/provider/resourcemanager	(cached) [no tests to run]
testing: warning: no tests to run
PASS
ok  	github.com/hashicorp/terraform-provider-hcp/internal/provider/vaultsecrets	(cached) [no tests to run]
=== RUN   TestAcc_dataSourcePackerBucketNames
--- PASS: TestAcc_dataSourcePackerBucketNames (12.94s)
=== RUN   TestAcc_dataSourcePackerImage_Simple
=== PAUSE TestAcc_dataSourcePackerImage_Simple
=== RUN   TestAcc_dataSourcePackerImage_IterationID
=== PAUSE TestAcc_dataSourcePackerImage_IterationID
=== RUN   TestAcc_dataSourcePackerImage_revokedIteration
=== PAUSE TestAcc_dataSourcePackerImage_revokedIteration
=== RUN   TestAcc_dataSourcePackerImage_emptyChannel
=== PAUSE TestAcc_dataSourcePackerImage_emptyChannel
=== RUN   TestAcc_dataSourcePackerImage_channelAndIterationIDReject
=== PAUSE TestAcc_dataSourcePackerImage_channelAndIterationIDReject
=== RUN   TestAcc_dataSourcePackerIteration_Simple
=== PAUSE TestAcc_dataSourcePackerIteration_Simple
=== RUN   TestAcc_dataSourcePackerIteration_revokedIteration
=== PAUSE TestAcc_dataSourcePackerIteration_revokedIteration
=== RUN   TestAcc_dataSourcePackerRunTask
--- PASS: TestAcc_dataSourcePackerRunTask (8.83s)
=== RUN   TestAccPackerChannelAssignment_SimpleSetUnset
=== PAUSE TestAccPackerChannelAssignment_SimpleSetUnset
=== RUN   TestAccPackerChannelAssignment_AssignLatest
=== PAUSE TestAccPackerChannelAssignment_AssignLatest
=== RUN   TestAccPackerChannelAssignment_InvalidInputs
=== PAUSE TestAccPackerChannelAssignment_InvalidInputs
=== RUN   TestAccPackerChannelAssignment_CreateFailsWhenPreassigned
=== PAUSE TestAccPackerChannelAssignment_CreateFailsWhenPreassigned
=== RUN   TestAccPackerChannelAssignment_HCPManagedChannelErrors
=== PAUSE TestAccPackerChannelAssignment_HCPManagedChannelErrors
=== RUN   TestAccPackerChannelAssignment_EnforceNull
=== PAUSE TestAccPackerChannelAssignment_EnforceNull
=== RUN   TestAccPackerChannelAssignment_AliasMigration
=== PAUSE TestAccPackerChannelAssignment_AliasMigration
=== RUN   TestAccPackerChannel
=== PAUSE TestAccPackerChannel
=== RUN   TestAccPackerChannel_HCPManaged
=== PAUSE TestAccPackerChannel_HCPManaged
=== RUN   TestAccPackerChannel_RestrictionDrift
=== PAUSE TestAccPackerChannel_RestrictionDrift
=== RUN   TestAccPackerChannel_RestrictionDriftHCPManaged
=== PAUSE TestAccPackerChannel_RestrictionDriftHCPManaged
=== RUN   TestAccPackerRunTask
--- PASS: TestAccPackerRunTask (19.98s)
=== CONT  TestAcc_dataSourcePackerImage_Simple
=== CONT  TestAccPackerChannelAssignment_InvalidInputs
=== CONT  TestAccPackerChannel
=== CONT  TestAccPackerChannel_RestrictionDrift
=== CONT  TestAccPackerChannel_HCPManaged
=== CONT  TestAccPackerChannelAssignment_EnforceNull
=== CONT  TestAccPackerChannelAssignment_AssignLatest
=== CONT  TestAccPackerChannelAssignment_AliasMigration
=== CONT  TestAccPackerChannelAssignment_HCPManagedChannelErrors
=== CONT  TestAccPackerChannelAssignment_CreateFailsWhenPreassigned
--- PASS: TestAccPackerChannelAssignment_InvalidInputs (3.84s)
=== CONT  TestAcc_dataSourcePackerImage_channelAndIterationIDReject
--- PASS: TestAcc_dataSourcePackerImage_channelAndIterationIDReject (0.24s)
=== CONT  TestAccPackerChannelAssignment_SimpleSetUnset
--- PASS: TestAccPackerChannelAssignment_HCPManagedChannelErrors (5.44s)
=== CONT  TestAcc_dataSourcePackerIteration_revokedIteration
--- PASS: TestAccPackerChannelAssignment_CreateFailsWhenPreassigned (10.44s)
=== CONT  TestAcc_dataSourcePackerIteration_Simple
--- PASS: TestAcc_dataSourcePackerImage_Simple (11.24s)
=== CONT  TestAcc_dataSourcePackerImage_revokedIteration
--- PASS: TestAcc_dataSourcePackerIteration_revokedIteration (6.62s)
=== CONT  TestAcc_dataSourcePackerImage_emptyChannel
--- PASS: TestAcc_dataSourcePackerImage_emptyChannel (2.43s)
=== CONT  TestAccPackerChannel_RestrictionDriftHCPManaged
--- PASS: TestAccPackerChannelAssignment_EnforceNull (15.21s)
=== CONT  TestAcc_dataSourcePackerImage_IterationID
--- PASS: TestAcc_dataSourcePackerImage_revokedIteration (5.94s)
--- PASS: TestAccPackerChannelAssignment_AssignLatest (18.03s)
--- PASS: TestAccPackerChannel (18.21s)
--- PASS: TestAccPackerChannelAssignment_AliasMigration (19.21s)
--- PASS: TestAccPackerChannelAssignment_SimpleSetUnset (15.21s)
--- PASS: TestAcc_dataSourcePackerIteration_Simple (8.86s)
--- PASS: TestAccPackerChannel_HCPManaged (20.13s)
--- PASS: TestAccPackerChannel_RestrictionDrift (20.28s)
--- PASS: TestAcc_dataSourcePackerImage_IterationID (6.26s)
--- PASS: TestAccPackerChannel_RestrictionDriftHCPManaged (19.38s)
PASS
ok  	github.com/hashicorp/terraform-provider-hcp/internal/providersdkv2	76.466s

...

JenGoldstrich

LGTM given past reviews on interim PRs, left one small comment!

JenGoldstrich · 2024-01-22T23:39:12Z

.changelog/726.txt

+```
+
+```release-note:feature
+`data.hcp_packer_version`: Added the `hcp_packer_version` data source, which replaces `data.hcp_packer_iteration`


Nit but maybe this should say "which will replace"

Did you think in the future because data.hcp_packer_iteration is still available? I would think that it is a replacement now because the added is deprecated from the time this PR is merged too. But I want to know your line of thought

delores-hashicorp

Rubber stamping

…el_assignment.iteration_fingerprint` (#136) * Add `version_fingerprint` attribute * Add migration/compatibility tests * Run `make gencheck` * Deprecate `iteration_fingerprint` * Update related changelogs

Co-authored-by: Sylvia Moss <[email protected]> Co-authored-by: Jenna Goldstrich <[email protected]> Co-authored-by: Devashish <[email protected]>

sylviamoss added the do-not-merge label Jan 19, 2024

sylviamoss marked this pull request as ready for review January 19, 2024 17:55

sylviamoss requested review from a team as code owners January 19, 2024 17:55

JenGoldstrich approved these changes Jan 22, 2024

View reviewed changes

delores-hashicorp approved these changes Jan 23, 2024

View reviewed changes

sylviamoss force-pushed the packer-nomenclature/main branch from 8ab494e to d6d7dba Compare January 24, 2024 13:33

aidan-mundy and others added 15 commits January 24, 2024 15:53

PRELIM: HPR-1516: Remove Deprecated Iteration Attributes

aa0d833

HPR-1513: Introduce version_fingerprint alias for `hcp_packer_chann…

d7c268b

…el_assignment.iteration_fingerprint` (#136) * Add `version_fingerprint` attribute * Add migration/compatibility tests * Run `make gencheck` * Deprecate `iteration_fingerprint` * Update related changelogs

HPR-1514: Packer Nomenclature Version Data Source (#140)

0400505

Co-authored-by: Sylvia Moss <[email protected]> Co-authored-by: Jenna Goldstrich <[email protected]> Co-authored-by: Devashish <[email protected]>

Move HCP Packer TFC resource to Packer API V2

ae9cd61

Fix run task data source

39b3516

Migrate Packer Channel resource to Packer API V2

af4d6c0

File name change

07bc142

Migrate Packer Channel Assignment resource to HCP Packer API V2

057ede7

tests

52612bc

bump hcp-sdk-go and update packer imports

4c4f006

migrate bucket names data source and fix tests

23bea8c

update changelog and guides

dcd2c68

update changelog file name

6c94e67

skip test configuration when acc test are disabled

65c535b

add buckets name test back

d2a498c

sylviamoss force-pushed the packer-nomenclature/main branch from d6d7dba to d2a498c Compare January 24, 2024 14:56

sylviamoss merged commit 64139a5 into main Jan 24, 2024
6 checks passed

sylviamoss deleted the packer-nomenclature/main branch January 24, 2024 15:44

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

HCP Packer new data sources and nomenclature changes #726

HCP Packer new data sources and nomenclature changes #726

sylviamoss commented Jan 19, 2024 •

edited

Loading

JenGoldstrich left a comment

JenGoldstrich Jan 22, 2024

sylviamoss Jan 23, 2024

delores-hashicorp left a comment

HCP Packer new data sources and nomenclature changes #726

HCP Packer new data sources and nomenclature changes #726

Conversation

sylviamoss commented Jan 19, 2024 • edited Loading

🛠️ Description

🏗️ Acceptance tests

JenGoldstrich left a comment

Choose a reason for hiding this comment

JenGoldstrich Jan 22, 2024

Choose a reason for hiding this comment

sylviamoss Jan 23, 2024

Choose a reason for hiding this comment

delores-hashicorp left a comment

Choose a reason for hiding this comment

sylviamoss commented Jan 19, 2024 •

edited

Loading