Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HPR-1512: Deprecate to-be-removed Iteration attributes #678

Merged
merged 3 commits into from
Nov 27, 2023
Merged

HPR-1512: Deprecate to-be-removed Iteration attributes #678

merged 3 commits into from
Nov 27, 2023

Conversation

aidan-mundy
Copy link
Contributor

🛠️ Description

  • Deprecate to-be-removed Iteration attributes
    • data.hcp_packer_iteration.incremental_version
    • hcp_packer_channel_assignment.iteration_version
    • hcp_packer_channel_assignment.iteration_id

@aidan-mundy aidan-mundy added the go Pull requests that update Go code label Nov 27, 2023
@aidan-mundy aidan-mundy marked this pull request as ready for review November 27, 2023 21:20
@aidan-mundy aidan-mundy requested a review from a team as a code owner November 27, 2023 21:20
JenGoldstrich
JenGoldstrich approved these changes Nov 27, 2023
View reviewed changes
Copy link
Contributor

@JenGoldstrich JenGoldstrich left a comment •
edited by aidan-mundy
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I validated these changes against the nomenclature changes doc

@aidan-mundy aidan-mundy merged commit 35a9d98 into main Nov 27, 2023
5 checks passed
@aidan-mundy aidan-mundy deleted the HPR-1512/deprecate-iteration-attributes branch November 27, 2023 22:29
@aidan-mundy aidan-mundy mentioned this pull request Nov 28, 2023
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JenGoldstrich JenGoldstrich JenGoldstrich approved these changes

Assignees
No one assigned
Labels
go Pull requests that update Go code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aidan-mundy @JenGoldstrich