Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for credential files #672

Merged
merged 4 commits into from
Nov 14, 2023
Merged

Add support for credential files #672

merged 4 commits into from
Nov 14, 2023

Conversation

dadgar
Copy link
Contributor

@dadgar dadgar commented Nov 14, 2023 •
edited
Loading

🛠️ Description

Add support for authenticating the provider using credential files. This will allow future integration with Terraform Cloud Dynamic Credentials.

🏗️ Acceptance tests

  • Are there any feature flags that are required to use this functionality? No
  • Have you added an acceptance test for the functionality being added? No
  • Have you run the acceptance tests on this branch? No

Output from acceptance testing:

Ran the provider with and confirmed it was authenticated:

  • A valid credential file
  • Client ID / Client Secret
  • Nothing set and browser was opened.
  • Tested the new validation rules work.

@dadgar dadgar merged commit 0ca1f76 into main Nov 14, 2023
6 checks passed
@dadgar dadgar deleted the f-provider-credentials branch November 14, 2023 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tobias-hashicorp tobias-hashicorp tobias-hashicorp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dadgar @tobias-hashicorp