generated from hashicorp/terraform-provider-scaffolding
-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for http observability on vault_cluster resource #660
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
http observability provider
improvement in changelog
bosouza
reviewed
Nov 1, 2023
to invalidProviderConfigError
…o specifiy that only basic or bearer authentication can be provided at any given time
should only be "JSON" or "NDJSON" values
that its value is either POST, PUT, or PATCH
…rm-provider-hcp into jaireddjawed-hcpv-http Merge changes from main
mercedesbh
reviewed
Nov 2, 2023
mercedesbh
reviewed
Nov 2, 2023
mercedesbh
reviewed
Nov 2, 2023
mercedesbh
reviewed
Nov 2, 2023
mercedesbh
reviewed
Nov 2, 2023
and http_basic_password description
bosouza
reviewed
Nov 6, 2023
from newrelic branch
validateHTTPAuth function
only set when the user provides authentication
bosouza
approved these changes
Nov 7, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
aidan-mundy
pushed a commit
that referenced
this pull request
Nov 9, 2023
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🛠️ Description
This PR adds custom HTTP endpoints as an option for observability providers on HCP Vault clusters. I tested this change by adding a unit test that verifies that all required params that are a part of this provider are defined (located in
internal/provider/resource_vault_cluster_config_test.go
and performed a manual test of these changes.Manual Test
Requirements
Steps
make dev
in the main directory of this repositoryterraform init
andterraform apply
in the directory of the terraform scriptPOST
), that the headers and bearer token are seen in the http requestVerified that http observability information appears in
/etc/vector.d/vector.json
Check to see if errors are valid
http_basic_user
is given, buthttp_basic_password
is not specifiedhttp_bearer_token
andhttp_basic_user
are specified🏗️ Acceptance tests
Output from acceptance testing: