Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't require trailing slash on issuer_uri #656

Merged
merged 2 commits into from
Oct 25, 2023
Merged

Don't require trailing slash on issuer_uri #656

merged 2 commits into from
Oct 25, 2023

Conversation

dadgar
Copy link
Contributor

@dadgar dadgar commented Oct 25, 2023

🛠️ Description

Fixes an issue where we required a trailing slash on the issuer_uri. This is an unnecessary restriction as the issuer can include or not include it. For example the HCP issuer includes it but the TFC issuer doesn't.

https://hashicorp.atlassian.net/browse/HCPIE-809

🏗️ Acceptance tests

  • Are there any feature flags that are required to use this functionality?
  • Have you added an acceptance test for the functionality being added?
  • Have you run the acceptance tests on this branch?

Output from acceptance testing:

$ TF_ACC=1 go test -v
=== RUN   TestAccServicePrincipalDataSource
--- PASS: TestAccServicePrincipalDataSource (10.84s)
=== RUN   TestAccServicePrincipalKeyResource
--- PASS: TestAccServicePrincipalKeyResource (42.48s)
=== RUN   TestAccServicePrincipalResource_Project
--- PASS: TestAccServicePrincipalResource_Project (21.88s)
=== RUN   TestAccServicePrincipalResource_ExplicitProject
--- PASS: TestAccServicePrincipalResource_ExplicitProject (11.78s)
=== RUN   TestAccServicePrincipalResource_Organization
--- PASS: TestAccServicePrincipalResource_Organization (13.29s)
=== RUN   TestAccWorkloadIdentityProviderResource
--- PASS: TestAccWorkloadIdentityProviderResource (19.05s)
PASS
ok      github.com/hashicorp/terraform-provider-hcp/internal/provider/iam       119.773s

Fixes an issue where we required a trailing slash on the issuer_uri.
This is an unnecessary restriction as the issuer can include or not
include it. For example the HCP issuer includes it but the TFC issuer
doesn't.
@dadgar dadgar requested a review from mpminardi October 25, 2023 22:30
@dadgar dadgar requested a review from a team as a code owner October 25, 2023 22:30
@dadgar dadgar merged commit d4e122e into main Oct 25, 2023
@dadgar dadgar deleted the b-issuer-uri branch October 25, 2023 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants