HCPE-909 - Add TGW attachment imports #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smaant
approved these changes
Feb 12, 2021
| hvnID := idParts[0] | ||
| tgwAttID := idParts[1] | ||
| loc := &sharedmodels.HashicorpCloudLocationLocation{ | ||
| ProjectID: client.Config.ProjectID, |
There was a problem hiding this comment.
aren't we also need an org-id here?
There was a problem hiding this comment.
This location is used to create the link format we use for ids (/project/123/hashicorp.network.tgw-attachment/456), so we only actually need the project id. The link format used to include more information, but since it is now only the project id that gets used, I'll make a note to consider simplifying this across our resources 🙏 .
There was a problem hiding this comment.
Ticket created: https://hashicorp.atlassian.net/browse/HCPE-915
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds import functionality, where the import id is
{hvn_id}:{transit_gateway_attachment_id}Most of the functionality matches what is already done with network peering.
One note: because
resource_share_arnis not available in our responses, it cannot be populated into Terraform state from an import. This is a known case that can be handled with anignore_changesblock (I've included this in the documentation here), but the preferred solution would be to include this value in the response, if that is an option here.