Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Project/Organization Resources / Data Sources #629

Merged
merged 9 commits into from
Oct 11, 2023
Merged

Add Project/Organization Resources / Data Sources #629

merged 9 commits into from
Oct 11, 2023

Conversation

dadgar
Copy link
Contributor

@dadgar dadgar commented Oct 10, 2023

🛠️ Description

This PR adds:

  • hcp_project: Resource and Data Source
  • hcp_organization: Data Source

🏗️ Acceptance tests

  • Are there any feature flags that are required to use this functionality?: NO
  • Have you added an acceptance test for the functionality being added?: YES
  • Have you run the acceptance tests on this branch?

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX'
TF_ACC=1 go test ./internal/... -v -run="TestAccProject|TestAccOrganization" -timeout 360m -parallel=10
testing: warning: no tests to run
PASS
ok      github.com/hashicorp/terraform-provider-hcp/internal/clients    (cached) [no tests to run]
testing: warning: no tests to run
PASS
ok      github.com/hashicorp/terraform-provider-hcp/internal/consul     (cached) [no tests to run]
testing: warning: no tests to run
PASS
ok      github.com/hashicorp/terraform-provider-hcp/internal/hcpvalidator       (cached) [no tests to run]
testing: warning: no tests to run
PASS
ok      github.com/hashicorp/terraform-provider-hcp/internal/input      (cached) [no tests to run]
?       github.com/hashicorp/terraform-provider-hcp/internal/provider/acctest   [no test files]
testing: warning: no tests to run
PASS
ok      github.com/hashicorp/terraform-provider-hcp/internal/provider   (cached) [no tests to run]
=== RUN   TestAccOrganizationDataSource
--- PASS: TestAccOrganizationDataSource (7.36s)
=== RUN   TestAccProjectDataSource
--- PASS: TestAccProjectDataSource (14.93s)
=== RUN   TestAccProjectResource
--- PASS: TestAccProjectResource (20.82s)
PASS
ok      github.com/hashicorp/terraform-provider-hcp/internal/provider/resourcemanager   43.495s
testing: warning: no tests to run
PASS
ok      github.com/hashicorp/terraform-provider-hcp/internal/providersdkv2      (cached) [no tests to run]

@dadgar dadgar requested review from a team and tobias-hashicorp October 10, 2023 22:16
@dadgar dadgar changed the title Add Resource Manager Resources / Data Sources Add Project/Organization Resources / Data Sources Oct 10, 2023
Copy link
Contributor

@tobias-hashicorp tobias-hashicorp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Just the role name needs adjusting.

docs/resources/project.md Outdated Show resolved Hide resolved
internal/provider/resourcemanager/resource_project.go Outdated Show resolved Hide resolved
docs/resources/project.md Outdated Show resolved Hide resolved
@dadgar dadgar merged commit de6be3a into main Oct 11, 2023
5 checks passed
@dadgar dadgar deleted the f-project branch October 11, 2023 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants