Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix test CI #591

Merged
merged 2 commits into from
Sep 12, 2023
Merged

fix test CI #591

merged 2 commits into from
Sep 12, 2023

Conversation

hashiblaum
Copy link
Member

🛠️ Description

Fixing acceptance test for hcp_vault_plugin resource by removing hard coded variables.

🏗️ Acceptance tests

  • Are there any feature flags that are required to use this functionality?
  • Have you added an acceptance test for the functionality being added?
  • Have you run the acceptance tests on this branch?

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccVaultPlugin'
==> Checking that code complies with gofmt requirements...
golangci-lint run --config ./golangci-config.yml 
TF_ACC=1 go test ./internal/... -v -run=TestAccVaultPlugin -timeout 360m -parallel=10
testing: warning: no tests to run
PASS
ok      github.com/hashicorp/terraform-provider-hcp/internal/clients    (cached) [no tests to run]
testing: warning: no tests to run
PASS
ok      github.com/hashicorp/terraform-provider-hcp/internal/consul     (cached) [no tests to run]
testing: warning: no tests to run
PASS
ok      github.com/hashicorp/terraform-provider-hcp/internal/input      (cached) [no tests to run]
=== RUN   TestAccVaultPlugin
--- PASS: TestAccVaultPlugin (925.98s)
PASS
ok      github.com/hashicorp/terraform-provider-hcp/internal/provider   926.897s

...

@hashiblaum hashiblaum requested a review from a team as a code owner September 12, 2023 14:45
.changelog/591.txt Outdated Show resolved Hide resolved
@hashiblaum hashiblaum merged commit d73d503 into main Sep 12, 2023
@hashiblaum hashiblaum deleted the test-fix branch September 12, 2023 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants