Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IFACE-1880: Enable RFC 6598 CIDR Range for HVN Route #515

Merged
merged 9 commits into from
May 30, 2023
Merged

IFACE-1880: Enable RFC 6598 CIDR Range for HVN Route #515

merged 9 commits into from
May 30, 2023

Conversation

jasonpilz
Copy link
Member

@jasonpilz jasonpilz commented May 26, 2023 •
edited
Loading

🛠️ Description

  • The network service has been updated to allow creation of HVN routes to RFC 6598. We need to support this functionality through the hcp_hvn_route resource as well.
  • This change updates the validation used on the destination_cidr attribute of the hcp_hvn_route resource to allow the additional network range (100.64.0.0/10)

Related

🏗️ Acceptance tests

  • Are there any feature flags that are required to use this functionality?
  • Have you added an acceptance test for the functionality being added?
  • Have you run the acceptance tests on this branch?

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX'

...

@jasonpilz jasonpilz self-assigned this May 26, 2023
@jasonpilz jasonpilz requested a review from bcmdarroch May 30, 2023 16:59
@jasonpilz jasonpilz marked this pull request as ready for review May 30, 2023 16:59
@jasonpilz jasonpilz requested a review from a team as a code owner May 30, 2023 16:59
@jasonpilz jasonpilz merged commit b02a523 into main May 30, 2023
@jasonpilz jasonpilz deleted the jasonpilz/IFACE-1880-hvn-route-rfc-6598 branch May 30, 2023 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhaggerty042 mhaggerty042 mhaggerty042 approved these changes

@pierluc-codes pierluc-codes pierluc-codes approved these changes

@bcmdarroch bcmdarroch Awaiting requested review from bcmdarroch

@mooneygr mooneygr Awaiting requested review from mooneygr

@dgregoire dgregoire Awaiting requested review from dgregoire

Assignees

@jasonpilz jasonpilz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jasonpilz @pierluc-codes @mhaggerty042