Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump to 1.18 #374

Merged
merged 2 commits into from
Aug 19, 2022
Merged

bump to 1.18 #374

merged 2 commits into from
Aug 19, 2022

Conversation

itsjaspermilan
Copy link
Contributor

@itsjaspermilan itsjaspermilan commented Aug 18, 2022

πŸ› οΈ Description

Bump the version of go specified in .go-version to 1.18 to stay in line with the rest of the app.

🚒 Release Note

Release note for CHANGELOG:

* provider: Bump version of Go to 1.18.5 in `.go-version` [GH-374]

@itsjaspermilan itsjaspermilan requested a review from a team August 18, 2022 19:44
Copy link

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me πŸš€

By the way, you can switch actions/setup-go to read the Go version from the go.mod file nowadays if you do not want this extra goenv-based file: https://github.com/actions/setup-go#getting-go-version-from-the-gomod-file

@itsjaspermilan itsjaspermilan merged commit 25ffc77 into main Aug 19, 2022
@itsjaspermilan itsjaspermilan deleted the bump-go-version branch August 19, 2022 14:08
rizkybiz pushed a commit to rizkybiz/terraform-provider-hcp that referenced this pull request Aug 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants