Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade go 1.18 #365

Merged
merged 4 commits into from
Aug 4, 2022
Merged

Upgrade go 1.18 #365

merged 4 commits into from
Aug 4, 2022

Conversation

bcmdarroch
Copy link
Contributor

@bcmdarroch bcmdarroch commented Aug 2, 2022

๐Ÿ› ๏ธ Description

Upgrades the provider to go version 1.18.

๐Ÿšข Release Note

Release note for CHANGELOG:

* provider: upgrade to 1.18 [GH-365]

๐Ÿ—๏ธ Acceptance tests

  • Have you run the acceptance tests on this branch?

Output from acceptance testing:

$ make testacc

PASS
ok  	github.com/hashicorp/terraform-provider-hcp/internal/provider	5510.161s

Also ran a manual test with a Consul cluster, upgrading from the latest version to the provider build with these changes.

  1. Initializing HVN + Consul cluster on 0.37.0:
$ terraform init
Initializing provider plugins...
- Finding hashicorp/hcp versions matching "~> 0.37.0"...
...

$ terraform apply
...
Apply complete! Resources: 2 added, 0 changed, 0 destroyed.
  1. Upgrading to local build with go upgrade:
$ terraform init
Initializing provider plugins...
- Finding localhost/providers/hcp versions matching "0.0.1"...
...

$ terraform apply
...
No changes. Your infrastructure matches the configuration.

Terraform has compared your real infrastructure against your configuration and found no differences, so no changes are needed.

Apply complete! Resources: 0 added, 0 changed, 0 destroyed.

@bcmdarroch bcmdarroch merged commit 8b52536 into main Aug 4, 2022
@bcmdarroch bcmdarroch deleted the upgrade-go-1.18 branch August 4, 2022 14:33
rizkybiz pushed a commit to rizkybiz/terraform-provider-hcp that referenced this pull request Aug 25, 2022
* bump 1.15 to 1.18

* go mod tidy

* bump version in provider checks

* bump required version in readme
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants