Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check type assertions in Vault cluster resource #364

Merged
merged 1 commit into from
Aug 2, 2022

Conversation

kkredit
Copy link
Contributor

@kkredit kkredit commented Aug 1, 2022

🛠️ Description

Check type assertions in Vault cluster resource to address #360.

🚢 Release Note

Release note for CHANGELOG:

* vault_cluster: Check type assertions to fix issue #360 [GH-364]

🏗️ Acceptance tests

  • Are there any feature flags that are required to use this functionality?
  • Have you added an acceptance test for the functionality being added?
  • Have you run the acceptance tests on this branch?

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX'

...

@kkredit kkredit requested a review from andrey-donelli August 1, 2022 19:57
Copy link
Contributor

@codergs codergs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@kkredit kkredit merged commit db2a392 into main Aug 2, 2022
@kkredit kkredit deleted the check-type-assertions-in-vault-cluster-resource branch August 2, 2022 15:27
rizkybiz pushed a commit to rizkybiz/terraform-provider-hcp that referenced this pull request Aug 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants