Log peering wait errors, use ReadTimeout in peering Data Sources #363
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🛠️ Description
Occasionally we get what look like timeouts while waiting on Azure peerings to flip to ACTIVE:
This repeatedly happens right at 20 minutes, which is the default timeout. That doesn't make a lot of sense, be we ourselves set the Timeout to 35 minutes in multiple places. The changes in this PR are to 1. try to log failures seen waiting on the peering state transition and 2. set the Read timeout to 35 minutes explicitly (vs using just
Timeouts.Default
).🚢 Release Note
Release note for CHANGELOG:
🏗️ Acceptance tests
Output from acceptance testing: