Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor hcp hvn docs #338

Merged
merged 2 commits into from
Jun 28, 2022
Merged

Refactor hcp hvn docs #338

merged 2 commits into from
Jun 28, 2022

Conversation

daneharrigan
Copy link
Contributor

@daneharrigan daneharrigan commented Jun 28, 2022 •
edited
Loading

🛠️ Description

  • The hcp_hvn documentation was AWS VPC specific. These changes make them more generic to support multiple cloud providers.
  • We also explained why you should specify production HVN CIDR block values.

🚢 Release Note

* docs: Refactor documentation for `hcp_hvn` resource [GH-337]

🏗️ Acceptance tests

  • Are there any feature flags that are required to use this functionality? No
  • Have you added an acceptance test for the functionality being added? No
  • Have you run the acceptance tests on this branch? No

Closes #337

@daneharrigan daneharrigan requested a review from a team as a code owner June 28, 2022 15:08
@daneharrigan daneharrigan requested a review from a team June 28, 2022 15:08
Dane Harrigan and others added 2 commits June 28, 2022 11:08
@daneharrigan daneharrigan force-pushed the refactor-hcp-hvn-docs branch from 740da27 to 7c9adda Compare June 28, 2022 15:09
bcmdarroch
bcmdarroch approved these changes Jun 28, 2022
View reviewed changes
Copy link
Contributor

@bcmdarroch bcmdarroch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@bcmdarroch bcmdarroch merged commit 77aa3d8 into main Jun 28, 2022
@bcmdarroch bcmdarroch deleted the refactor-hcp-hvn-docs branch June 28, 2022 16:25
aidan-mundy pushed a commit that referenced this pull request Sep 8, 2023
@daneharrigan @dgregoire @bcmdarroch
Refactor hcp hvn docs (#338)
e8b22e2 
* Refactor hcp_hvn cloud provider documentation to be more generic

Co-authored-by: Dominic Gregoire <[email protected]>

* Regenerate documentation

Co-authored-by: Dominic Gregoire <[email protected]>

Co-authored-by: Dominic Gregoire <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bcmdarroch bcmdarroch bcmdarroch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

update hcp_hvn resource documentation
2 participants
@daneharrigan @bcmdarroch