Keep failed resources, add state output value

[jjti]

This is the same couple changes as the other PR targeting Consul but applied to networks and Vault as well:

1. keep failed resources in state
   • this helps for cleaning of resources
2. export resource state as an output value

closes: #222

🛠️ Description

🚢 Release Note

Release note for CHANGELOG:

* resource/vault: keep failed clusters, export state [GH-331]
* resource/hvn: keep failed networks/peerings, export state [GH-331]

🏗️ Acceptance tests

• Are there any feature flags that are required to use this functionality?
• Have you added an acceptance test for the functionality being added?
• Have you run the acceptance tests on this branch?

Output from acceptance testing:

→ make testacc TESTARGS='-run=TestAccAwsHvnOnly'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/... -v -run=TestAccAwsHvnOnly -timeout 210m
?       github.com/hashicorp/terraform-provider-hcp/internal/clients    [no test files]
testing: warning: no tests to run
PASS
ok      github.com/hashicorp/terraform-provider-hcp/internal/consul     (cached) [no tests to run]
testing: warning: no tests to run
PASS
ok      github.com/hashicorp/terraform-provider-hcp/internal/input      (cached) [no tests to run]
=== RUN   TestAccAwsHvnOnly
--- PASS: TestAccAwsHvnOnly (163.97s)
PASS
ok      github.com/hashicorp/terraform-provider-hcp/internal/provider   164.359s


→ make testacc TESTARGS='-run=TestAccHvnRoute'  
==> Checking that code complies with gofmt requirements...
...
=== RUN   TestAccHvnRoute
    resource_hvn_route_test.go:82: TestCase error running init: exit status 1
        
        Error: Incompatible provider version
        
        Provider registry.terraform.io/hashicorp/aws v2.64.0 does not have a package
        available for your current platform, darwin_arm64.

hitting issues with a provider version on the route test

[bcmdarroch]

I was thinking we should add this check to all the Reads, but it appears that not all the resources have a DELETED state. So I guess we'll just make sure to check on any resource with that state. 👍 (which you've done!)

[bcmdarroch]

Testing output:

--- PASS: TestAccAwsHvnOnly (170.69s)
ok  	github.com/hashicorp/terraform-provider-hcp/internal/provider	171.230s

--- PASS: TestAccAwsPeering (733.26s)
ok  	github.com/hashicorp/terraform-provider-hcp/internal/provider	733.602s

--- PASS: TestAccTGWAttachment (738.99s)
ok  	github.com/hashicorp/terraform-provider-hcp/internal/provider	739.340s

--- PASS: TestAccVaultCluster (3159.01s)
ok  	github.com/hashicorp/terraform-provider-hcp/internal/provider	3159.483s

I'm having troubles with timeouts on the Azure peering test. But I do think this is safe to merge.

I'll wrap up testing this change against existing resources (the acceptance tests only cover newly created resources) and then hopefully this should be good to go! 🎉

[bcmdarroch]

Just completed a manual test to verify existing resources are not impacted. I created the following resources using the latest HCP provider version, v0.32.0:

• AWS HVN
• AWS network peering
• AWS transit gateway
• AWS HVN route
• Vault cluster

1. Sample TF state, created on v0.32.0

# Vault cluster in TF state
{
    "mode": "managed",
    "type": "hcp_vault_cluster",
    "name": "test",
    "provider": "provider[\"registry.terraform.io/hashicorp/hcp\"]",
    "instances": [
        {
            "schema_version": 0,
            "attributes": {
                "cloud_provider": "aws",
                "cluster_id": "test-vault-cluster",
                "created_at": "2022-06-22T19:50:41.440Z",
                ...
            },
            "dependencies": [
                "hcp_hvn.test"
            ]
        }
    ]
}

2. Output after switching to this branch's local binary and running apply

Apply complete! Resources: 0 added, 0 changed, 0 destroyed.

# Vault cluster in TF state, now refreshed with `state`
{
    "mode": "managed",
    "type": "hcp_vault_cluster",
    "name": "test",
    "provider": "provider[\"registry.terraform.io/hashicorp/hcp\"]",
    "instances": [
        {
            "schema_version": 0,
            "attributes": {
                "cloud_provider": "aws",
                "cluster_id": "test-vault-cluster",
                "created_at": "2022-06-22T19:50:41.440Z",
                "state": "RUNNING",
                ...
            },
            "dependencies": [
                "hcp_hvn.test"
            ]
        }
    ]
}

*I tried to test the Azure resources but I'm experiencing timeout issues. I feel confident this is a safe change to merge, and we can address the testing issues separately.