Add CIDR Validator that matches backend validator #214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lackeyjb
reviewed
Oct 25, 2021
bcmdarroch
approved these changes
Oct 26, 2021
| input string | ||
| expected diag.Diagnostics | ||
| }{ | ||
| "blank input string": { |
There was a problem hiding this comment.
nit on test case organization: I would start with all of the valid test cases together followed by the invalid test cases. and probably worth throwing in a comment line to break them up
|
|
||
| func validateCIDRBlock(v interface{}, path cty.Path) diag.Diagnostics { | ||
| var diagnostics diag.Diagnostics | ||
|
|
There was a problem hiding this comment.
I'd add a comment here clarifying what rules are being enforced here (so, the first two documented here: https://registry.terraform.io/providers/hashicorp/hcp/latest/docs/resources/hvn)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🛠️ Description
Adds CIDR Validator and tests to list of validators to match backend validators