Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HCS-2061: Add size upgrade field for consul cluster update #168

Merged
merged 3 commits into from
Aug 11, 2021
Merged

Conversation

ellacai
Copy link
Contributor

@ellacai ellacai commented Jul 19, 2021

Changes

  • remove ForceNew on consul cluster size field - we want to update the resource instead of destroy and recreate
  • modify resourceConsulClusterUpdate to handle size change
  • note: the logic to validate size upgrade paths is already in consul service so it is not needed here

Testing

  • tested size upgrade using terraform with consul cluster in integration (currently behind launchdarkly flag)

Acceptance Criteria:

  • HCP TF provider should call the consul-service update cluster API on a change in the value for size , instead of re-creating the cluster.
  • The PR should be approved from a consul-service engineer and a TCE team engineer
  • PR will not be merged until monitoring is added

@ellacai ellacai requested a review from a team as a code owner July 19, 2021 21:47
@ellacai ellacai requested a review from a team July 19, 2021 21:47
@hashicorp-cla
Copy link

hashicorp-cla commented Jul 19, 2021

CLA assistant check
All committers have signed the CLA.

@ellacai ellacai changed the title [wip] HCS-2061: Add size upgrade field for consul cluster update HCS-2061: Add size upgrade field for consul cluster update Jul 22, 2021
Copy link
Contributor

@lackeyjb lackeyjb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, but could we add some updates to the acceptance tests for this change?

Copy link
Contributor

@lackeyjb lackeyjb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@ellacai ellacai merged commit 54299c4 into main Aug 11, 2021
@ellacai ellacai deleted the HCS-2061 branch August 11, 2021 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants