Add auto peering for Consul Federation

[hanshasselberg]

🛠️ Description

This PR adds the new parameter auto_hvn_to_hvn_peering to consul clusters. It enables the user to decided if they want to use automatic peering during federation or not. Needs https://github.com/hashicorp/cloud-consul-service/pull/1253.

This PR also semi depends on #156 because right now there is no way to create a manual peering.

🏗️ Acceptance tests

• Are there any feature flags that are required to use this functionality?
• Have you added an acceptance test for the functionality being added?
• Have you run the acceptance tests on this branch?

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccConsul'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/... -v -run=TestAccConsul -timeout 120m
?   	github.com/hashicorp/terraform-provider-hcp/internal/clients	[no test files]
testing: warning: no tests to run
PASS
ok  	github.com/hashicorp/terraform-provider-hcp/internal/consul	(cached) [no tests to run]
testing: warning: no tests to run
PASS
ok  	github.com/hashicorp/terraform-provider-hcp/internal/input	(cached) [no tests to run]


=== RUN   TestAccConsulCluster
--- PASS: TestAccConsulCluster (553.00s)
=== RUN   TestAccConsulSnapshot
--- PASS: TestAccConsulSnapshot (591.61s)
PASS
ok  	github.com/hashicorp/terraform-provider-hcp/internal/provider	1144.969s

[hanshasselberg]

I still need to generate the docs!

[bcmdarroch]

Looks good so far! I'd echo all of @riddhi89's comments, and I'd like to get some more product/design input on how updates to auto_peering should be handled.

[hanshasselberg]

I removed the default, and re-added ForceNew.

[hanshasselberg]

Running integration tests right now.

[bcmdarroch]

This is close! I have a few more questions, and some doc suggestions. I don't have all the feature flag set up for testing this locally, so I'll leave that to you to verify :)

[bcmdarroch]

Ah I did see a panic on my run of the acceptance test, looks like on the data source step:

panic: Invalid address to set: []string{"auto_hvn_to_hvn_peering"}

goroutine 915 [running]:
github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema.(*ResourceData).Set(0xc000c42380, 0x1ee0956, 0x17, 0x1ce92a0, 0x278c6e0, 0x0, 0x0)
	$GOPATH/pkg/mod/github.com/hashicorp/terraform-plugin-sdk/[email protected]/helper/schema/resource_data.go:230 +0x371
github.com/hashicorp/terraform-provider-hcp/internal/provider.setConsulClusterResourceData(0xc000c42380, 0xc000b99380, 0xc0007aab90, 0xc00094fdd0, 0xc000b94450)
	$GOPATH/src/github.com/hashicorp/terraform-provider-hcp/internal/provider/resource_consul_cluster.go:462 +0x85b
github.com/hashicorp/terraform-provider-hcp/internal/provider.dataSourceConsulClusterRead(0x20ebd98, 0xc000b98240, 0xc000c42380, 0x1cbd9a0, 0xc000d6e0b0, 0xc000667f40, 0xc00076f948, 0x100fff8)
	$GOPATH/src/github.com/hashicorp/terraform-provider-hcp/internal/provider/data_source_consul_cluster.go:171 +0x5d6
github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema.(*Resource).read(0xc000148000, 0x20ebd28, 0xc000d14280, 0xc000c42380, 0x1cbd9a0, 0xc000d6e0b0, 0x0, 0x0, 0x0)

[bcmdarroch]

Nice work! Just two last few nits but otherwise this looks good to go! And acceptance tests are passing now 👍 👍

[hanshasselberg]

@bcmdarroch yeah the panic was caused by the missing changes related to the data-source.

[hanshasselberg]

@bcmdarroch @riddhi89 thank you both for your reviews! I think it is done.

[riddhi89]

Tested it out manually. LGTM