Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vault cluster 'tier' added as an optional input #144

Merged
merged 12 commits into from
Jun 15, 2021

Conversation

waxb
Copy link
Contributor

@waxb waxb commented Jun 10, 2021

πŸ› οΈ Description

Added tier as a required option for Vault clusters.
#143

πŸ—οΈ Acceptance tests

  • Are there any feature flags that are required to use this functionality? no
  • Have you added an acceptance test for the functionality being added?
  • Have you run the acceptance tests on this branch?

Output from acceptance testing:

waxb@mbp:terraform-provider-hcp (vault-cluster-tier *)$ make testacc TESTARGS='-run=TestAccVaultCluster'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/... -v -run=TestAccVaultCluster -timeout 120m
?   	github.com/hashicorp/terraform-provider-hcp/internal/clients	[no test files]
testing: warning: no tests to run
PASS
ok  	github.com/hashicorp/terraform-provider-hcp/internal/consul	(cached) [no tests to run]
testing: warning: no tests to run
PASS
ok  	github.com/hashicorp/terraform-provider-hcp/internal/input	(cached) [no tests to run]
=== RUN   TestAccVaultClusterAdminToken
--- PASS: TestAccVaultClusterAdminToken (778.24s)
=== RUN   TestAccVaultCluster
--- PASS: TestAccVaultCluster (771.51s)
PASS
ok  	github.com/hashicorp/terraform-provider-hcp/internal/provider	1550.281s

Note: TestAccVaultClusterAdminToken tests for standard_small

@waxb waxb requested a review from a team June 10, 2021 16:24
@hashicorp-cla
Copy link

hashicorp-cla commented Jun 10, 2021

CLA assistant check
All committers have signed the CLA.

@waxb waxb marked this pull request as draft June 10, 2021 16:26
Copy link
Contributor

@bcmdarroch bcmdarroch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @waxb! Thank you for this contribution πŸŽ‰

There's just a couple build issues that need fixing, and a few suggestions I left. Once you resolve those we can get this in!

internal/provider/resource_vault_cluster.go Outdated Show resolved Hide resolved
internal/provider/resource_vault_cluster.go Outdated Show resolved Hide resolved
internal/provider/resource_vault_cluster.go Outdated Show resolved Hide resolved
Wax, Bence added 2 commits June 11, 2021 10:04
@waxb waxb marked this pull request as ready for review June 11, 2021 08:29
@waxb
Copy link
Contributor Author

waxb commented Jun 11, 2021

Also I realised that the docu is autogenerated :-)

@waxb waxb requested a review from bcmdarroch June 11, 2021 08:41
@waxb waxb marked this pull request as draft June 11, 2021 08:49
@waxb waxb marked this pull request as ready for review June 11, 2021 12:09
@waxb waxb changed the title Tier added as a required input Vault cluster 'tier' added as a required input Jun 11, 2021
@waxb waxb marked this pull request as draft June 11, 2021 15:52
@waxb waxb marked this pull request as ready for review June 11, 2021 17:57
@waxb waxb requested a review from bcmdarroch June 11, 2021 17:57
@waxb waxb marked this pull request as draft June 11, 2021 18:10
@waxb waxb marked this pull request as ready for review June 11, 2021 18:38
@waxb waxb changed the title Vault cluster 'tier' added as a required input Vault cluster 'tier' added as an optional input Jun 11, 2021
@waxb waxb marked this pull request as draft June 14, 2021 16:49
@waxb waxb marked this pull request as ready for review June 14, 2021 17:33
@waxb waxb requested a review from bcmdarroch June 14, 2021 17:33
Copy link
Contributor

@bcmdarroch bcmdarroch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work on this! Thanks for your patience with my reviews! πŸŽ‰

Once merged, I should be able to cut a release in the next few days.

@bcmdarroch bcmdarroch merged commit 5a50ee0 into hashicorp:main Jun 15, 2021
@waxb
Copy link
Contributor Author

waxb commented Jun 17, 2021

Thank you @nadilas for answering my funky golang questions!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants