-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Vault cluster 'tier' added as an optional input #144
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @waxb! Thank you for this contribution π
There's just a couple build issues that need fixing, and a few suggestions I left. Once you resolve those we can get this in!
β¦ed tiers got 'standard_' prefix
Also I realised that the docu is autogenerated :-) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent work on this! Thanks for your patience with my reviews! π
Once merged, I should be able to cut a release in the next few days.
Thank you @nadilas for answering my funky golang questions! |
π οΈ Description
Added
tier
as a required option for Vault clusters.#143
ποΈ Acceptance tests
Output from acceptance testing:
Note: TestAccVaultClusterAdminToken tests for
standard_small