-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Misc doc updates #119
Misc doc updates #119
Conversation
and remove quick-start
as that feature is still in beta
.github/PULL_REQUEST_TEMPLATE.md
Outdated
Hashicorp contributors, please consider: what stage of release is your feature in? | ||
If the feature is for internal Hashicorp usage only, it should be maintained on a feature branch until ready for beta release. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🙌
Super nit: I think HashiCorp
is preferred over Hashicorp
, so might be good to be consistent even in this messaging
@@ -20,6 +20,17 @@ The HCP provider supports authentication via a Client ID and a Client Secret. Th | |||
|
|||
## Example Usage | |||
|
|||
Everything in HashiCorp Cloud Platform (HCP) starts with the HashiCorp Virtual Network (HVN). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we change the heading from Example Usage
to something else like Getting Started
? When I read this section within the context of the Example Usage
heading, some of the explanation and instruction seemed slightly out of place.
to one that more accurately represents content
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding the beta banner for federation 👍
[auto] Sync with Public Provider
🛠️ Description
This PR takes care of a few doc updates in advance of Monday's release: