Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HVS use stable/2023-11-28 api #1142

Merged
merged 2 commits into from
Nov 21, 2024
Merged

HVS use stable/2023-11-28 api #1142

merged 2 commits into from
Nov 21, 2024

Conversation

keeefer
Copy link
Contributor

@keeefer keeefer commented Nov 21, 2024

🛠️ Description

Bump sdk version. Removes HVS preview in favor of using API V2 (stable/2023-11-28)

🏗️ Acceptance tests

  • Are there any feature flags that are required to use this functionality?
  • Have you added an acceptance test for the functionality being added?
  • Have you run the acceptance tests on this branch?

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX'

...

@keeefer keeefer marked this pull request as ready for review November 21, 2024 17:34
@keeefer keeefer requested review from a team as code owners November 21, 2024 17:34
Copy link
Member

@jasonpilz jasonpilz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks!

Copy link
Contributor

@averche averche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@keeefer keeefer merged commit 4233dae into main Nov 21, 2024
6 checks passed
@keeefer keeefer deleted the hv-1434-hvs-use-apiv2 branch November 21, 2024 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants