Bump sdk version + fix hvs breaking changes #1122
Conversation
|
|
|
Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement Learn more about why HashiCorp requires a CLA and what the CLA includes Have you signed the CLA already but the status is still pending? Recheck it. |
Whoops disregard above, misread your comment. We just return the config atm, but since |
| @@ -23,7 +23,7 @@ type DataSourceVaultSecretsRotatingSecretModel struct { | |||
| AppName types.String `tfsdk:"app_name"` | |||
| ProjectID types.String `tfsdk:"project_id"` | |||
| OrgID types.String `tfsdk:"organization_id"` | |||
| SecretName types.String `tfsdk:"secret_name"` | |||
| Name types.String `tfsdk:"name"` | |||
There was a problem hiding this comment.
I think we should leave this as SecretName since this is part of the TF provider data source API. Changing it will break existing TF configs.
I know that the version is pre 1.0 and according to symver we can push breaking change but we should consider to keep thing as they are. |
| @@ -0,0 +1,3 @@ | |||
| ```release-note:improvement | |||
| Upgrade the HCP SDK and fix breaking change w/ Vault Secrets | |||
| ``` | |||
There was a problem hiding this comment.
Should we leave out the breaking change part of the changelog notes?
For someone that consumes the provider, they only care that the SDK was bumped and things work exactly like they used to. Seeing "breaking change" might trigger some false alarms.
There was a problem hiding this comment.
Ah good point, ill update
🛠️ Description
Bump sdk version link.
Use
nameinstead ofsecret_namefor rotating secrets.🏗️ Acceptance tests
Output from acceptance testing:
$ make testacc TESTARGS='-run=TestAccXXX' ...