Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update hcp-sdk-go #1113

Merged
merged 6 commits into from
Oct 11, 2024
Merged

update hcp-sdk-go #1113

merged 6 commits into from
Oct 11, 2024

Conversation

dhuckins
Copy link
Contributor

@dhuckins dhuckins commented Oct 9, 2024

🛠️ Description

update to the latest version of the hcp-sdk-go/compare/v0.115.0...v0.116.0

🏗️ Acceptance tests

  • Are there any feature flags that are required to use this functionality?
  • Have you added an acceptance test for the functionality being added?
  • Have you run the acceptance tests on this branch?

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX'

...

trentdibacco
trentdibacco approved these changes Oct 9, 2024
View reviewed changes
Copy link
Contributor

@trentdibacco trentdibacco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dhuckins dhuckins marked this pull request as ready for review October 9, 2024 17:33
@dhuckins dhuckins requested review from a team as code owners October 9, 2024 17:33
@trentdibacco trentdibacco mentioned this pull request Oct 10, 2024
Merged
21 tasks
@dhuckins dhuckins merged commit cd7cff2 into main Oct 11, 2024
6 checks passed
@dhuckins dhuckins deleted the dh/update-hcp-sdk-go branch October 11, 2024 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pierluc-codes pierluc-codes pierluc-codes approved these changes

@keeefer keeefer keeefer approved these changes

@trentdibacco trentdibacco trentdibacco approved these changes

@averche averche Awaiting requested review from averche

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dhuckins @pierluc-codes @keeefer @trentdibacco