added self_link to hvn, peering and tgw attachment #111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
nombiezinja
reviewed
Apr 23, 2021
bcmdarroch
reviewed
Apr 23, 2021
There was a problem hiding this comment.
Looks good! My only ask: could you update the acceptance tests too? https://github.com/hashicorp/terraform-provider-hcp/blob/main/internal/provider/resource_hvn_test.go
|
@bcmdarroch good point, thank you for noticing! updated the test |
bcmdarroch
reviewed
Apr 26, 2021
| @@ -102,6 +106,41 @@ func testAccCheckHvnExists(name string) resource.TestCheckFunc { | |||
| } | |||
| } | |||
|
|
|||
| func testSelfLink(name string, expectedID, expectedType string) resource.TestCheckFunc { | |||
There was a problem hiding this comment.
thanks for adding this! probably something we could share with future tests :)
There was a problem hiding this comment.
yes, this is how I saw it too
bcmdarroch
approved these changes
Apr 26, 2021
aidan-mundy
added a commit
that referenced
this pull request
Sep 8, 2023
[auto] Sync with Public Provider
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🛠️ Description
Added
self_linkattribute to hvn, peering and tgw attachment resources and datasources.