Waypoint acceptance test bugfixes #1094
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…odule that it references
…e, as well as the test looking for the wrong variables
…rewrite it or remove it as it has never worked in its current state
HenryEstberg
force-pushed
the
waypoint-addon-deprecation-fix
branch
from
0b754f4 to
9034d74
Compare
The re-pinned older version of the module doesn't have these variables.
Co-authored-by: Joe <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🛠️ Description
This PR starts to address the large number of currently failing Waypoint acceptance tests. Before these changes 12 tests were failing, with these fixes in place that number is down to 7. The different fixes all have their own commits. Some of these bugs only affected the tests but most had some effect on the actual use of the provider, preventing users from successfully navigating it.