Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ICU-12824-Add-Boundary-version-of-the-cluster-to-the-hcp_boundary_cluster-resource-data-source #1089

Merged
merged 5 commits into from
Sep 11, 2024
Merged

ICU-12824-Add-Boundary-version-of-the-cluster-to-the-hcp_boundary_cluster-resource-data-source #1089

merged 5 commits into from
Sep 11, 2024

Conversation

RyanDerr
Copy link
Member

@RyanDerr RyanDerr commented Sep 11, 2024 •
edited
Loading

🛠️ Description

  • Updated the hcp_boundary_cluster resources & data sources for collecting version information for deployed or existing clusters.

🏗️ Acceptance tests

  • Are there any feature flags that are required to use this functionality?
  • Have you added an acceptance test for the functionality being added?
  • Have you run the acceptance tests on this branch?

Output from acceptance testing:

image

@hashicorp-cla-app HashiCorp CLA App
Copy link

hashicorp-cla-app bot commented Sep 11, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@RyanDerr RyanDerr changed the title Ryan/boundary-cluster-version Add Version Attributes To Boundary Cluster Resource & Data Source Sep 11, 2024
@RyanDerr RyanDerr self-assigned this Sep 11, 2024
@RyanDerr RyanDerr marked this pull request as ready for review September 11, 2024 16:24
@RyanDerr RyanDerr requested review from a team as code owners September 11, 2024 16:24
davidsbond
davidsbond approved these changes Sep 11, 2024
View reviewed changes
Copy link
Member

@davidsbond davidsbond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@RyanDerr RyanDerr merged commit d1e7ef1 into main Sep 11, 2024
6 checks passed
@RyanDerr RyanDerr deleted the ryan/boundary-cluster-version branch September 11, 2024 16:49
@RyanDerr RyanDerr changed the title Add Version Attributes To Boundary Cluster Resource & Data Source ICU-12824-Add-Boundary-version-of-the-cluster-to-the-hcp_boundary_cluster-resource-data-source Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidsbond davidsbond davidsbond approved these changes

@pierluc-codes pierluc-codes pierluc-codes approved these changes

Assignees

@RyanDerr RyanDerr

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@RyanDerr @pierluc-codes @davidsbond