Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: increase codeowner coverage #1086

Merged
merged 2 commits into from
Nov 4, 2024
Merged

chore: increase codeowner coverage #1086

merged 2 commits into from
Nov 4, 2024

Conversation

pierluc-codes
Copy link
Contributor

🛠️ Description

🏗️ Acceptance tests

  • Are there any feature flags that are required to use this functionality?
  • Have you added an acceptance test for the functionality being added?
  • Have you run the acceptance tests on this branch?

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX'

...

@pierluc-codes pierluc-codes added the pr/no-changelog Auto-pinning label Sep 6, 2024
@pierluc-codes pierluc-codes marked this pull request as ready for review September 6, 2024 21:51
@pierluc-codes pierluc-codes requested a review from a team as a code owner September 6, 2024 21:51
jasonpilz
jasonpilz reviewed Sep 9, 2024
View reviewed changes
.github/CODEOWNERS Outdated Show resolved Hide resolved
@pierluc-codes pierluc-codes merged commit ad44265 into main Nov 4, 2024
6 checks passed
@pierluc-codes pierluc-codes deleted the pierluc-codes/codeowner branch November 4, 2024 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasonpilz jasonpilz jasonpilz approved these changes

Assignees
No one assigned
Labels
pr/no-changelog Auto-pinning
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pierluc-codes @jasonpilz