Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added HVS MongoDB Atlas integration resource #1084

Merged
merged 8 commits into from
Sep 9, 2024

Conversation

maxcoulombe
Copy link
Contributor

🛠️ Description

  • Added a new resource for the HVS MongoDBAtlas Integration

🏗️ Acceptance tests

  • Are there any feature flags that are required to use this functionality?
  • Have you added an acceptance test for the functionality being added?
  • Have you run the acceptance tests on this branch?

Output from acceptance testing:

Screenshot from 2024-09-05 15-32-35

@maxcoulombe maxcoulombe requested review from a team as code owners September 5, 2024 19:36
Copy link
Contributor

@averche averche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 Thanks for putting this together!

}
i.ResourceID = types.StringValue(integrationModel.ResourceID)
i.ResourceName = types.StringValue(integrationModel.ResourceName)
i.Name = types.StringValue(integrationModel.Name)
Copy link
Contributor Author

@maxcoulombe maxcoulombe Sep 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The bug has been fixed upstream, the update response returns all the fields so we do not need to fall back on the saved state anymore.

Copy link
Member

@jasonpilz jasonpilz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@maxcoulombe maxcoulombe merged commit 6e53488 into main Sep 9, 2024
6 checks passed
@maxcoulombe maxcoulombe deleted the vault-29949/MongoDBAtlas-Integration-Resource branch September 9, 2024 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants