Implemented HVS Twilio Integration resource #1081
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- removed test secrets * generate doc + changelog + added import instructions * lint * anonymized example variables - remove compact summary to view changes * patch doc
maxcoulombe
requested review from
austingebauer,
averche,
dhuckins and
keeefer
jasonpilz
approved these changes
Sep 4, 2024
averche
approved these changes
Sep 5, 2024
| client, ok := req.ProviderData.(*clients.Client) | ||
| if !ok { | ||
| resp.Diagnostics.AddError( | ||
| "Unexpected Data Source Configure Type", |
There was a problem hiding this comment.
Nit: is the error expected to be formatted in Title Case?
There was a problem hiding this comment.
Good question, this config block is used by ~30 different resources this is just some shared boilerplate so I'm not sure if this was intended but I'll keep it for consistency with the others.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🛠️ Description
🏗️ Acceptance tests
Output from acceptance testing:
